Update minimum PHP version to 5.3.2 #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may as well bump it to 5.3.3 |
|
Bumped to 5.3.3 (note that this is the version used by RHEL 6 so hopefully min PHP version won't go beyond 5.3.3) |
|
👎 Composer depends on this package. |
|
I'm fine with 5.3.2 but was requested to change it to 5.3.3. Whichever the maintainers prefer I will make it so. |
siwinski
force-pushed
the
pr-update-min-php-version-to-5-3-2
branch
from
1e5f43c to
3e45ca4
Compare
|
Rebased and repushed. |
siwinski
force-pushed
the
pr-update-min-php-version-to-5-3-2
branch
from
3e45ca4 to
cffdeb7
Compare
bin/validate-json uses stream_resolve_include_path() which is only available in PHP >= 5.3.2
siwinski
force-pushed
the
pr-update-min-php-version-to-5-3-2
branch
from
cffdeb7 to
d81a42b
Compare
|
Re-based to current master and reverted commits to original pull request of min PHP version of 5.3.2 |
|
👍 |
|
Also, composer itself depends on php 5.3.2+, so you literally can't install this package on php 5.3.0... |
|
Could we get this merged? |
|
+1 |
bighappyface
added a commit
that referenced
this pull request
Jun 11, 2015
Update minimum PHP version to 5.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/validate-jsonusesstream_resolve_include_path()which is only available in PHP >= 5.3.2