Skip to content

Fix #827 #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix #827 #828

wants to merge 7 commits into from

Conversation

DannyvdSluijs
Copy link
Collaborator

@DannyvdSluijs DannyvdSluijs commented May 23, 2025

This PR will:

  • Scan schemas that are being added for id properties and register them if valid schemas
  • Avoid altering the id for sibling ref properties

This will fix #827

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #827 by enhancing schema scanning and preventing unintended alterations to sibling ref properties. Key changes include:

  • Updating function signatures with strict type hints and return types in both SchemaStorageInterface and SchemaStorage.
  • Switching to strict equality (===) for schema id comparisons.
  • Adding a recursive subschema registration method in SchemaStorage to scan for nested id properties.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/JsonSchema/SchemaStorageInterface.php Updated function signatures with type hints and return types.
src/JsonSchema/SchemaStorage.php Enhanced addSchema and expandRefs methods for better reference resolution and introduced subschema registration.
phpstan-baseline.neon Adjusted baseline messages to reflect type validations and return type updates.
CHANGELOG.md Updated changelog with new issue fix information.
Comments suppressed due to low confidence (1)

src/JsonSchema/SchemaStorage.php:105

  • [nitpick] The variable names '$parentId' and '$childId' are used to manage schema reference resolution; adding a brief comment or using more descriptive names may improve clarity for future maintainers.
            if (property_exists($schema, 'id') && is_string($schema->id) && $childId !== $schema->id) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

id's not being resolved and id property affects sibling ref which it should not do
1 participant