Skip to content

fix #341 validate-json command #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

remicollet
Copy link
Contributor

Seems to work, please review as I'm probably not an expert of this library.

@shmax
Copy link
Collaborator

shmax commented Dec 12, 2016

We're not all experts, either. Perhaps you could provide a little background? Eg. what problem are you solving here, what was wrong with the existing code, what does your fix change, etc...

@remicollet
Copy link
Contributor Author

@shmax see #341

@shmax
Copy link
Collaborator

shmax commented Dec 12, 2016

Ah, okay. LGTM

@bighappyface bighappyface merged commit 1da8622 into jsonrainbow:master Dec 12, 2016
@remicollet remicollet deleted the issue-tst branch December 23, 2016 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants