Skip to content

Fix various details in README.md #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2016
Merged

Conversation

rtucek
Copy link
Contributor

@rtucek rtucek commented Nov 25, 2016

Add newline after heading and code block (consistency).

Use triple backticks for bash code examples.

Change how library will be installed via composer.

Remove explicit version constraint in composer require example. Recent
versions of composer will default the most recent version and
set a non-major breaking constraint.
Version constraint was still pointing to the most recent version of 2.*
release.

Soft limit text to 80 chars (does node affect code examples).

Remove 'Basic usage' heading.

Fix heading 'Type coercion' (space and typo).

Add missing opening PHP tag (section 'Type coercion'.

Fix indentation in code example (consistent 4 spaces).

Use single backticks for inline code.
Add parenthesis to method in description.

Add newline after heading and code block (consistency).

Use triple backticks for bash code examples.

Change how library will be installed via composer.

Remove explicit version constraint in `composer require` example. Recent
versions of composer will default the most recent version and
set a non-major breaking constraint.
Version constraint was still pointing to the most recent version of 2.*
release.

Soft limit text to 80 chars (does node affect code examples).

Remove 'Basic usage' heading.

Fix heading 'Type coercion' (space and typo).

Add missing opening PHP tag (section 'Type coercion'.

Fix indentation in code example (consistent 4 spaces).

Use single backticks for inline code.
Add parenthesis to method in description.
@rtucek
Copy link
Contributor Author

rtucek commented Nov 25, 2016

Btw, it took me longer to document the changes in the commit message than changing in the source... 😄

Copy link
Collaborator

@shmax shmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bighappyface bighappyface merged commit a942b98 into jsonrainbow:master Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants