-
Notifications
You must be signed in to change notification settings - Fork 356
Exception interface #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bighappyface
merged 1 commit into
jsonrainbow:master
from
abacaphiliac:exception-interface
Jul 25, 2016
Merged
Exception interface #278
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?php | ||
|
||
namespace JsonSchema\Exception; | ||
|
||
interface ExceptionInterface | ||
{ | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the JsonSchema package. | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace JsonSchema\Exception; | ||
|
||
/** | ||
* Wrapper for the RuntimeException | ||
*/ | ||
class RuntimeException extends \RuntimeException implements ExceptionInterface | ||
{ | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,6 @@ | |
* @package JsonSchema\Exception | ||
* @author Joost Nijhuis <[email protected]> | ||
*/ | ||
class UnresolvableJsonPointerException extends \InvalidArgumentException | ||
class UnresolvableJsonPointerException extends InvalidArgumentException | ||
{ | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<?php | ||
|
||
namespace JsonSchema\Tests\Exception; | ||
|
||
use JsonSchema\Exception\InvalidArgumentException; | ||
|
||
class InvalidArgumentExceptionTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testHierarchy() | ||
{ | ||
$exception = new InvalidArgumentException(); | ||
self::assertInstanceOf('\InvalidArgumentException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<?php | ||
|
||
namespace JsonSchema\Tests\Exception; | ||
|
||
use JsonSchema\Exception\InvalidSchemaMediaTypeException; | ||
|
||
class InvalidSchemaMediaTypeExceptionTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testHierarchy() | ||
{ | ||
$exception = new InvalidSchemaMediaTypeException(); | ||
self::assertInstanceOf('\RuntimeException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<?php | ||
|
||
namespace JsonSchema\Tests\Exception; | ||
|
||
use JsonSchema\Exception\InvalidSourceUriException; | ||
|
||
class InvalidSourceUriExceptionTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testHierarchy() | ||
{ | ||
$exception = new InvalidSourceUriException(); | ||
self::assertInstanceOf('\InvalidArgumentException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\InvalidArgumentException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
<?php | ||
|
||
namespace JsonSchema\Tests\Exception; | ||
|
||
use JsonSchema\Exception\JsonDecodingException; | ||
|
||
class JsonDecodingExceptionTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testHierarchy() | ||
{ | ||
$exception = new JsonDecodingException(); | ||
self::assertInstanceOf('\RuntimeException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception); | ||
} | ||
|
||
public function testDefaultMessage() | ||
{ | ||
$exception = new JsonDecodingException(); | ||
self::assertNotEmpty($exception->getMessage()); | ||
} | ||
|
||
public function testErrorNoneMessage() | ||
{ | ||
$exception = new JsonDecodingException(JSON_ERROR_NONE); | ||
self::assertNotEmpty($exception->getMessage()); | ||
} | ||
|
||
public function testErrorDepthMessage() | ||
{ | ||
$exception = new JsonDecodingException(JSON_ERROR_DEPTH); | ||
self::assertNotEmpty($exception->getMessage()); | ||
} | ||
|
||
public function testErrorStateMismatchMessage() | ||
{ | ||
$exception = new JsonDecodingException(JSON_ERROR_STATE_MISMATCH); | ||
self::assertNotEmpty($exception->getMessage()); | ||
} | ||
|
||
public function testErrorControlCharacterMessage() | ||
{ | ||
$exception = new JsonDecodingException(JSON_ERROR_CTRL_CHAR); | ||
self::assertNotEmpty($exception->getMessage()); | ||
} | ||
|
||
public function testErrorUtf8Message() | ||
{ | ||
$exception = new JsonDecodingException(JSON_ERROR_UTF8); | ||
self::assertNotEmpty($exception->getMessage()); | ||
} | ||
|
||
public function testErrorSyntaxMessage() | ||
{ | ||
$exception = new JsonDecodingException(JSON_ERROR_SYNTAX); | ||
self::assertNotEmpty($exception->getMessage()); | ||
} | ||
|
||
public function testErrorInfiniteOrNotANumberMessage() | ||
{ | ||
if (!defined('JSON_ERROR_INF_OR_NAN')) { | ||
self::markTestSkipped('JSON_ERROR_INF_OR_NAN is not defined until php55.'); | ||
} | ||
|
||
$exception = new JsonDecodingException(JSON_ERROR_INF_OR_NAN); | ||
self::assertNotEmpty($exception->getMessage()); | ||
} | ||
|
||
public function testErrorRecursionMessage() | ||
{ | ||
if (!defined('JSON_ERROR_RECURSION')) { | ||
self::markTestSkipped('JSON_ERROR_RECURSION is not defined until php55.'); | ||
} | ||
|
||
$exception = new JsonDecodingException(JSON_ERROR_RECURSION); | ||
self::assertNotEmpty($exception->getMessage()); | ||
} | ||
|
||
public function testErrorUnsupportedTypeMessage() | ||
{ | ||
if (!defined('JSON_ERROR_UNSUPPORTED_TYPE')) { | ||
self::markTestSkipped('JSON_ERROR_UNSUPPORTED_TYPE is not defined until php55.'); | ||
} | ||
|
||
$exception = new JsonDecodingException(JSON_ERROR_UNSUPPORTED_TYPE); | ||
self::assertNotEmpty($exception->getMessage()); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<?php | ||
|
||
namespace JsonSchema\Tests\Exception; | ||
|
||
use JsonSchema\Exception\ResourceNotFoundException; | ||
|
||
class ResourceNotFoundExceptionTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testHierarchy() | ||
{ | ||
$exception = new ResourceNotFoundException(); | ||
self::assertInstanceOf('\RuntimeException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<?php | ||
|
||
namespace JsonSchema\Tests\Exception; | ||
|
||
use JsonSchema\Exception\RuntimeException; | ||
|
||
class RuntimeExceptionTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testHierarchy() | ||
{ | ||
$exception = new RuntimeException(); | ||
self::assertInstanceOf('\RuntimeException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<?php | ||
|
||
namespace JsonSchema\Tests\Exception; | ||
|
||
use JsonSchema\Exception\UnresolvableJsonPointerException; | ||
|
||
class UnresolvableJsonPointerExceptionTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testHierarchy() | ||
{ | ||
$exception = new UnresolvableJsonPointerException(); | ||
self::assertInstanceOf('\InvalidArgumentException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\InvalidArgumentException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<?php | ||
|
||
namespace JsonSchema\Tests\Exception; | ||
|
||
use JsonSchema\Exception\UriResolverException; | ||
|
||
class UriResolverExceptionTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testHierarchy() | ||
{ | ||
$exception = new UriResolverException(); | ||
self::assertInstanceOf('\RuntimeException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\RuntimeException', $exception); | ||
self::assertInstanceOf('\JsonSchema\Exception\ExceptionInterface', $exception); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These series of test are best done as a dataProvider