Skip to content

Fix: Constraint::addError() does not return anything #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2015
Merged

Fix: Constraint::addError() does not return anything #167

merged 1 commit into from
Jul 13, 2015

Conversation

localheinz
Copy link
Contributor

This PR

  • calls a method, then returns, rather than attempting to return the result of a method which does not return anything

@bighappyface
Copy link
Collaborator

+1 makes sense.

bighappyface added a commit that referenced this pull request Jul 13, 2015
@bighappyface
Merge pull request #167 from localheinz/fix/return
44adc6f 
Fix: Constraint::addError() does not return anything
@bighappyface bighappyface merged commit 44adc6f into jsonrainbow:master Jul 13, 2015
@localheinz localheinz deleted the fix/return branch July 13, 2015 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @bighappyface