Fetching JSON Array from URI #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'm looking forward to having this request pulled. |
|
+1 |
| @@ -150,7 +150,10 @@ public function retrieve($uri, $baseUri = null) | |||
|
|
|||
| // Use the JSON pointer if specified | |||
| $jsonSchema = $this->resolvePointer($jsonSchema, $resolvedUri); | |||
| $jsonSchema->id = $resolvedUri; | |||
|
|
|||
| if ($jsonSchema instanceof \StdClass) { | |||
There was a problem hiding this comment.
Let's go with lower-camelCase stdClass and I will merge.
|
@bighappyface - Thanks David, I've updated the PR as requested. |
|
+1 |
bighappyface
added a commit
that referenced
this pull request
Jun 13, 2015
Fetching JSON Array from URI
|
Great - thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you fetch a json array from a URI then a warning is thrown.
This is due to ``JsonSchema\Uri\UriRetriever::retrieve` attempting to get the 'id' property of the array.
This pull request contains a simple fix and a test