Skip to content

remove composer.lock #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2015
Merged

Conversation

keradus
Copy link
Contributor

@keradus keradus commented Mar 27, 2015

No description provided.

This was referenced Mar 27, 2015
@bighappyface
Copy link
Collaborator

What's up with the failing test?

@keradus
Copy link
Contributor Author

keradus commented Mar 27, 2015

it looks like this project fails with lowest php and deps...

@keradus
Copy link
Contributor Author

keradus commented Mar 27, 2015

Min version of PHP seems to be ok.
Min deps version looks messed up: https://travis-ci.org/justinrainbow/json-schema/builds/56147406

@keradus keradus force-pushed the composer_lock branch 2 times, most recently from e390098 to 03ff7d6 Compare March 27, 2015 20:58
@keradus keradus changed the title remove composer.lock, test on travis with lowest deps remove composer.lock Mar 27, 2015
@keradus
Copy link
Contributor Author

keradus commented Mar 27, 2015

Remove testing lowest deps from travis, please check what they should be and add it yourself.

Ready to merge.

@bighappyface
Copy link
Collaborator

May we add the self-update and --prefer-source back in? It's noisy without them.

https://travis-ci.org/justinrainbow/json-schema/jobs/56150828#L217-L225

@keradus keradus force-pushed the composer_lock branch 2 times, most recently from 73fceaf to 53ce3f0 Compare March 27, 2015 21:37
@keradus
Copy link
Contributor Author

keradus commented Mar 27, 2015

machines without sudo have newer composer, but here you need sudo :(

@keradus
Copy link
Contributor Author

keradus commented Mar 27, 2015

selfupdate back in there.
composer cache wont work with prefer-source (but dist won't work with buggy SSL connection on sudo-mechines, so back in there as well)

@bighappyface
Copy link
Collaborator

+1

bighappyface added a commit that referenced this pull request Mar 27, 2015
@bighappyface bighappyface merged commit 0c16b51 into jsonrainbow:master Mar 27, 2015
@keradus keradus deleted the composer_lock branch March 27, 2015 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants