Skip to content

Do not throw errors when using unknown/custom format #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2015
Merged

Do not throw errors when using unknown/custom format #125

merged 1 commit into from
Jun 11, 2015

Conversation

lwiesel
Copy link
Contributor

@lwiesel lwiesel commented Feb 11, 2015

No description provided.

@bighappyface
Copy link
Collaborator

@lwiesel would you please rebase and resolve conflicts? Also, would you mind reviewing #134 to see how this update could factor in?

@Maks3w
Copy link
Contributor

Maks3w commented Apr 4, 2015

For the record I attach the specification fragment about this:

The value of this keyword is called a format attribute. It MUST be a string. A format attribute can generally only validate a given set of instance types. If the type of the instance to validate is not in this set, validation for this format attribute and instance SHOULD succeed.
http://json-schema.org/latest/json-schema-validation.html#anchor105

@Maks3w
Copy link
Contributor

Maks3w commented Apr 4, 2015

@bighappyface The PR is rebased. Travis-CI error status is due failure with composer install

@Maks3w
Copy link
Contributor

Maks3w commented Apr 4, 2015

@bighappyface #134 (now #141) should be rebased again when this is merged or you could resolve the conflict

@onlinesid
Copy link
Contributor

I screwed up my PR so I've closed and re-created it as #142

I've removed unknown format error, updated the tests and squashed my commits into one

@lwiesel
Copy link
Contributor Author

lwiesel commented Apr 7, 2015

Ok, since github is fine again these days, the Travis-CI build passed after my rebase.

These modifications are indeed included in PR #142, but I'd recommend to merge this PR before and keep #142 focused on optional extra argument to keep atomicity in commits. Anyway it's your call!

@bighappyface
Copy link
Collaborator

+1

bighappyface added a commit that referenced this pull request Jun 11, 2015
Do not throw errors when using unknown/custom format
@bighappyface bighappyface merged commit 1ffdea0 into jsonrainbow:master Jun 11, 2015
Maks3w added a commit to Maks3w/SwaggerAssertions that referenced this pull request Jun 13, 2015
Maks3w added a commit to Maks3w/SwaggerAssertions that referenced this pull request Jun 13, 2015
Maks3w added a commit to Maks3w/SwaggerAssertions that referenced this pull request Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants