Skip to content

id's not being resolved and id property affects sibling ref which it should not do #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DannyvdSluijs opened this issue May 23, 2025 · 0 comments · May be fixed by #828
Open

id's not being resolved and id property affects sibling ref which it should not do #827

DannyvdSluijs opened this issue May 23, 2025 · 0 comments · May be fixed by #828

Comments

@DannyvdSluijs
Copy link
Collaborator

There is as test that actually test for this (which we are failing, see Bowtie).

The failure is due to two reasons

  1. The SchemaStorage::addSchema() method doesn't scan added schemas for an id property (at the same level as properties or type) which should be used in resolving refs. This is why we get errors about file_get_contents(http://localhost:1234/sibling_id/foo.json) failed.

  2. When the id is altered for underlying schema this directly affects refs at the same level and the ones that have a shared parent. This is caused by the code here which adjust the base for ref's at the same level and even for other

@DannyvdSluijs DannyvdSluijs self-assigned this May 23, 2025
@DannyvdSluijs DannyvdSluijs linked a pull request May 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant