Relative paths resolving to unit test, not the schema

[tekmosis]

When using Laravel's packages we have JSON Schemas in multiple directories. Each one can be referenced and we're hoping to use it with relative paths. This works fine in Laravel with the validation on form request, it uses the relative path to the .schema.json

However with this package the relative path is of the unit test.

[erayd]

Could you provide a concise example please?

Relative paths should resolve relative to their parents schema. If there is no parent schema, then a relative path isn't valid - you must supply an absolute one.

[uncaught]

Yes, there is a bug in the UriResolver::combineRelativePathWithBasePath - I've written a test:

use JsonSchema\Uri\UriResolver;
use PHPUnit\Framework\Constraint\IsEqual;
use PHPUnit\Framework\TestCase;

class UriResolverTest extends TestCase {

  public function testcombineRelativePathWithBasePath(): void {
    $base = '/var/packages/flow-api/tests/UnitTests/DemoData/../../../schema/Customer/CustomerSchema_latest.json';
    $relative = '../../../schema/UuidSchema.json';
    $combined = UriResolver::combineRelativePathWithBasePath($relative, $base);
    $expectedPath =
      '/var/packages/flow-api/tests/UnitTests/DemoData/../../../schema/Customer/../../../schema/UuidSchema.json';
    $expectedRealPath = '/var/packages/schema/UuidSchema.json';
    self::assertThat(
      $combined,
      self::logicalOr(
        new IsEqual($expectedPath),
        new IsEqual($expectedRealPath)
      )
    );
  }
}

Failed asserting that '/var/packages/flow-api/tests/UnitTests/DemoData/../../schema/UuidSchema.json' is equal to '/var/packages/flow-api/tests/UnitTests/DemoData/../../../schema/Customer/../../../schema/UuidSchema.json' or is equal to '/var/packages/schema/UuidSchema.json'.

I've yet to understand, why the Method combineRelativePathWithBasePath is so complicated. Can't you simply use a dirname($basePath) . "/$relativePath"? And if you want to shorten it, a realpath() on the result, will do.

[DannyvdSluijs]

@tekmosis @uncaught in an attempt to cleanup this repo we are trying to filter the issues and see which ones might be closed. Is it safe to assume this is a rather old issue, which might not be worth pursuing? Feel free to close it yourself with some comments if helpful.

Also @uncaught in #652 you're using the word dirname but the name of the class is UriResolver and although a path on disk is a valid uri we should also consider the broader scope of other uri's. Would you say the PR is still something we should look at or is it not something you're still passionate about?

[uncaught]

We've been using my fork in production for nearly 2 years now. This is a bug and without the fix our tests fail.

The dirname is just a string operation, it is not limited to file paths and also works for URLs. It doesn't work on the actual file system.