Skip to content

Add the Code of Conduct and fix hydration issues due to markdown link references #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Feb 16, 2024

GitHub Issue: #278
Fixes: #278

Summary: Add the Code of Conduct and fix hydration issues due to markdown link references
Changes included:

  • Adding the CoC through submodule + symlink
  • Fixed hydration issues due to markdown link references

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

No

… references

* Adding the CoC through submodule + symlink
* Fixed hydration issues due to markdown link references
Copy link

cloudflare-workers-and-pages bot commented Feb 16, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2531b8
Status: ✅  Deploy successful!
Preview URL: https://2c02362f.website-2v2.pages.dev
Branch Preview URL: https://benjagm-coc.website-2v2.pages.dev

View logs

@benjagm
Copy link
Collaborator Author

benjagm commented Feb 19, 2024

Feedback provided in Slack. Great work... just some additional changes pending.

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few naming suggestions but otherwise looks good and produces the required result. Thanks.

@benjagm benjagm merged commit 76847a6 into main Feb 22, 2024
@benjagm benjagm deleted the benjagm-coc branch February 22, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host the Code of Conduct in the website
2 participants