-
-
Notifications
You must be signed in to change notification settings - Fork 316
Conversation
exclusiveMinimum and exclusiveMaximum are no longer boolean values changing the behaviour of respectively the minimum and maximum keywords, but are now fully independent keywords incompatible with minimum and maximum.
Cool! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! A few minor changes and one or two questions, but otherwise this is great. Thanks for your hard work.
source/reference/array.rst
Outdated
some schema as well. This is done using the ``items`` and | ||
``additionalItems`` keywords. | ||
some schema as well. This is done using the ``items``, | ||
``additionalItems`` and ``contains`` keywords. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oxford comma please.
Hey, at least I'm reviewing it!
source/reference/generic.rst
Outdated
JSON Schema includes a few keywords, ``title``, ``description`` and | ||
``default``, that aren't strictly used for validation, but are used to | ||
describe parts of a schema. | ||
JSON Schema includes a few keywords, ``title``, ``description``, ``default`` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oxford comma
source/reference/numeric.rst
Outdated
@@ -149,46 +149,78 @@ Range | |||
''''' | |||
|
|||
Ranges of numbers are specified using a combination of the | |||
``minimum``, ``maximum``, ``exclusiveMinimum`` and | |||
``exclusiveMaximum`` keywords. | |||
``minimum`` and ``maximum`` keywords (or ``exclusiveMinimum`` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comma
source/reference/schema.rst
Outdated
|
||
JSON Schema hyperschema written against the current version of the | ||
specification. | ||
version of the JSON Schema standard, you can include the draft name in the path, for example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/can/should/
@@ -139,46 +141,190 @@ schema for a customer: | |||
} | |||
} | |||
|
|||
.. note:: | |||
|
|||
Even though the value of a ``$ref`` is a URI, it is not a network locator, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not need to be network accessible, but it also may be.
source/structuring.rst
Outdated
} | ||
|
||
However, a loop of ``$ref`` schemas referring to one another could cause | ||
infinite recursion in the validator, and is explicitly disallowed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth expanding this to explain that loops are allowed, but this example shows an unresolveable $ref resolution loop, not a validation loop?
Thanks. I've updated based on your feedback. (I'm an Oxford comma fan, but U.S. grad school beat it out of me, so I've ended up rather inconsistent.) |
@Relequestual : Do changes address your concerns? |
@mdboom @Relequestual might be a bit delayed in responding right now, I'll message you on slack with more info |
I'm going to merge this to move forward, since I think it's mostly correct. File issues and PRs for things that aren't! |
This is a work-in-progress branch updating the document to refer to Draft 6.
Ideally, draft 7 will come shortly after Julian/jsonschema supports it, so the examples can continue to be automatically verified.