This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Cleanup and fixes for annotations #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenetheridge
approved these changes
May 2, 2021
|
You're right, I'll try to do whitespace changes in separate commits in the future. I'm also hoping to have build previews working well enough that reviewers can use that as well. |
|
I also added documentation for the |
Co-authored-by: Karen Etheridge <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly formatting changes, but also trims some things I didn't think were relevant. The main thing I wanted to change here was the suggestion that
defaultcould affect validation.