Name media type keywords consistently. #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlax
approved these changes
Sep 15, 2017
jsonschema-hyperschema.xml
Outdated
| @@ -425,7 +425,7 @@ | |||
| <section title="Submitting data for processing"> | |||
| <t> | |||
| The <xref target="submissionSchema">"submissionSchema"</xref> and | |||
| <xref target="submissionEncType">"submissionEncType"</xref> keywords | |||
| <xref target="submissionMediaType">"submissionMediaType"</xref> keywords | |||
| describe the domain of the processing function implemented by the target | |||
| resource. Otherwise, as noted above, the submission schema and encoding are | |||
There was a problem hiding this comment.
The line above still talks about "encoding". Maybe change to media type. (This is the only place in the document where "encoding" is used, AFAICT.)
There was a problem hiding this comment.
Good catch. I'd mostly done search-and-replace with a bit of skimming, it did not occur to me to search for "encoding" for some reason.
This addresses issue json-schema-org#409. "submissionEncType" is actually a media type, not an encoding, so name it accordingly. Rename "mediaType" to "targetMediaType" to make it unambiguous and fit with "target" and "targetHints".
dlax
approved these changes
Sep 18, 2017
philsturgeon
approved these changes
Sep 18, 2017
awwright
approved these changes
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #409. Which I just filed, so if the whole thing
gets rejected, no worries. I can also remove the
targetMediaTypepart if that is more controversial.
"submissionEncType" is actually a media type, not an encoding,
so name it accordingly. Rename "mediaType" to "targetMediaType"
to make it unambiguous and fit with "target" and "targetHints".