Skip to content

Support date and time, and allow for more RFC 3339 #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2017

Conversation

handrews
Copy link
Contributor

@handrews handrews commented Sep 8, 2017

This addresses #199 by supporting the two least controversial and
most requested addtional date/time formats, and reserving the
remaining namespace while we decide whether or how to specify
additional RFC 3339 formats.

This addresses json-schema-org#199 by supporting the two least controversial and
most requested addtional date/time formats, and reserving the
remaining namespace while we decide whether or how to specify
additional RFC 3339 formats.
@handrews handrews added this to the draft-07 (wright-*-02) milestone Sep 8, 2017
5.6</xref>.
Implementations MAY support additional attributes using the other
production names defined in that section. If implementing
"full-date" or "full-time", the corresponding short form ("date"
Copy link
Member

@dlax dlax Sep 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beginning of "If implementing..." sentence is not clear to me. Did you mean something like If "full-date" or "full-time" is implemented, the corresponding...?

Copy link
Member

@dlax dlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost fine :)

representation as defined by <xref target="RFC3339">RFC 3339, section
5.6</xref>.
Implementations MAY support additional attributes using the other
production names defined in that section. If "full-date" or "full-time",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing comma shouldn't be there, I guess.

@handrews handrews merged commit 96984f0 into json-schema-org:master Sep 22, 2017
@handrews handrews deleted the date-time branch October 18, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants