Add "headerSchema" #390
Merged
Add "headerSchema" #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlax
approved these changes
Sep 6, 2017
jsonschema-hyperschema.xml
Outdated
| <t> | ||
| <cref> | ||
| As with "targetHints", this keyword is somewhat under-specified | ||
| to encourage experiementation and feedback as we try to balance |
There was a problem hiding this comment.
It's extra-experimental and experiential!
Closed
handrews
force-pushed
the
header
branch
3 times, most recently
from
2ace99d to
92c12b8
Compare
dlax
reviewed
Sep 14, 2017
links.json
Outdated
| @@ -38,6 +38,12 @@ | |||
| "mediaType": { | |||
| "type": "string" | |||
| }, | |||
| "headerSchema": { | |||
| "description": "Schema for protocol-specific headers or analogous data, as signified by URI scheme", | |||
There was a problem hiding this comment.
Maybe drop "description" here as well?
There was a problem hiding this comment.
srsly? I swear I've pushed three times as many rebases/fixes as there are PRs tonight...
dlax
approved these changes
Sep 14, 2017
This addresses the request half of json-schema-org#296, and is a companion keyword to "targetHints" (json-schema-org#383). Like "targetHints", this is a rough first pass to get the discussion of specifics started. I expect it to be somewhat underspecified to encourage experimentation. I intentionally chose an example that is both very complex and very useful. It might also be worth putting up a simpler example. Although when this appears right after "targetHints", the simpler header value examples in that section will help motivate what is going on here.
|
Last call- barring objections or reasonable requests for more time to review, this will get merged tomorrow. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the request half of #296, and is a companion
keyword to "targetHints" (#383).
Like "targetHints", this is a rough first pass to get the
discussion of specifics started. I expect it to be somewhat
underspecified to encourage experimentation.
I intentionally chose an example that is both very complex
and very useful. It might also be worth putting up a simpler
example. Although when this appears right after "targetHints",
the simpler header value examples in that section will help
motivate what is going on here.