Highlight the challenges of extending meta-schemas #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
approved these changes
Sep 2, 2017
dlax
suggested changes
Sep 2, 2017
jsonschema-core.xml
Outdated
| <t> | ||
| Note that the recursive nature of meta-schemas requires re-definining | ||
| recursive keywords in the extended meta-schema, as can be seen in | ||
| ith the JSON Hyper-Schema meta-schema. |
There was a problem hiding this comment.
Thanks! I'll fix and then merge, as I don't think this fundamentally changes the approval and this has no impact on implementations at all.
This addresses the original question posed in json-schema-org#86, which noted that simply saying that meta-schemas can be extended with "allOf" is misleading and likely to lead to errors.
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the original question posed in #86, which
noted that simply saying that meta-schemas can be extended
with "allOf" is misleading and likely to lead to errors.