Skip to content

Add Travis CI build #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Add Travis CI build #370

merged 1 commit into from
Aug 28, 2017

Conversation

adamvoss
Copy link
Contributor

This adds automatic running of xml2rfc on the spec files. When a tag is pushed it has CD functionality to publish the build HTML and text files to GitHub Releases.

IMPORTANT: The api_key will need to be changed by someone that can generate a key for this repository. The one there is for my fork, which I used for testing. Additionally, a project member will need to enable this repository on Travis CI for this to do anything at all :-)

adamvoss referenced this pull request Aug 25, 2017
This file has exactly the contents of the front wiki page, except
for the I-D and meta-schema publishing processes which are not
relevant to most contributors.

I'm moving it into a CONTRIBUTING.md as it integrates with
GitHub's tools (e.g. auto-linking it to the create PR screen)
and will allow us to discuss changes as PRs.

I will change the front wiki page to link to this (but retain
the sections that have not been moved here).
@dlax
Copy link
Member

dlax commented Aug 25, 2017

Great idea!
It's not clear to me if this only works for tags? I think it's worth having xml2rfc run for any PR.

@handrews
Copy link
Contributor

@dlax @adamvoss release process was really something @awwright owned, so I'd rather get his input, probably better done in issues rather than directly to PRs.

@adamvoss
Copy link
Contributor Author

adamvoss commented Aug 25, 2017

@dlax The script section will run for all commits, so if any of the xml2rfc calls fail it will fail the build. Publication to GitHub Releases is restricted to tags.

@handrews I understand this may need to sit for a while and be discussed. This automates step 2 from the existing I-D Publish Process. The only variation is that it does not tar the files making them easier to access (and no longer and inconvenience when uploading since the process is automatic).

@dlax
Copy link
Member

dlax commented Aug 25, 2017

The script section will run for all commits, so if any of the xml2rfc calls fail it will fail the build.

That's already a clear improvement in itself. If the release aspect needs more thinking/discussion, why not just activating the script section now? The other section could be moved to a separate PR and further discussed.

@adamvoss
Copy link
Contributor Author

@DiaX I have now split the commit so that will be easy to do if that is what is decided.

@handrews
Copy link
Contributor

@adamvoss I'd be happy to accept the simple build script commit now. If you haven't already, please park the release idea in an issue and we'll revisit it when the right people are available. Based on past outcomes in process and release management discussions, I am not willing to make changes on my own at this time.

@handrews handrews merged commit 22a10fb into json-schema-org:master Aug 28, 2017
@adamvoss adamvoss deleted the ci-build branch August 28, 2017 15:15
@handrews
Copy link
Contributor

@adamvoss I have enabled the repo in Travis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants