Standardize format of meta-schemas. #186
Conversation
|
@awwright This does not have any actual changes beyond formatting, please review and merge ASAP. |
This brings formatting and most of the initial field ordering in line with the Draft 05 meta-schemas proposed in the web site repo. Also ensure that hyper-schema's definition of "schemaArray" cannot get out of sync with schema's, and add the link schema.
| @@ -66,17 +64,26 @@ | |||
| "type": "string" | |||
| } | |||
| } | |||
| }, | |||
| "readOnly": { | |||
There was a problem hiding this comment.
I can see readOnly in draft-5 (aka latest), so am happy with this.
| @@ -0,0 +1,42 @@ | |||
| { | |||
| "$schema": "http://json-schema.org/draft/hyper-schema#", | |||
There was a problem hiding this comment.
When the draft 4 version had the URI of draft-4/hyper-schema, why do we not use the URI of draft-5/hyper-schema? (Or will that be a later PR?)
There was a problem hiding this comment.
Because this is for "master" so it's not a numbered draft (at least that's how @awwright set it up and I was trying to not change it- take a look at the "id" of the hyper-schema).
| "id": "http://json-schema.org/draft/links#", | ||
| "title": "Link Description Object", | ||
| "type": "object", | ||
| "required": [ "href" ], |
There was a problem hiding this comment.
draft 4 version at https://github.com/json-schema-org/json-schema-org.github.io/blob/master/draft-04/links#L6 includes "rel" as required. Was this changed in draft 4? (Just checking)
There was a problem hiding this comment.
No, it was changed in draft 5. I made those changes later in the sequence for hyper-schema.json but forgot to "backport" links.json to a draft-4-compatible state. I just pulled it over as-is from the draft 5 changes I made on the website. I can change it if preferred.
|
As this doesn't change anything functionally, I see no reason to daley merging, which will enable further PRs. |
This brings formatting and most of the initial field ordering
in line with the Draft 05 meta-schemas proposed in the web site
repo.
Also ensure that hyper-schema's definition of "schemaArray"
cannot get out of sync with schema's, and add the link schema.