Updates for Relative JSON Pointer #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking the index of the result of an index manipulation was shown in the example and intended to work, but left out of the ABNF apparently by accident. Also, rework the ABNF to keep it within the text RFC line width.
Also, use <sourcecode> tag.
Somehow this was left out of the main syntax description paragraph entirely.
The current draft allows for an index adjustment of "0" which creates ambiguity because "1/foo", "1+0/foo", and "1-0/foo" are now three different ways to write a pointer with the exact same effect. This complicates round-trips between textual and functional representations, the original text would need to be preserved in order to re-constitute it correctly. There is no need for this added complication.
Relequestual
reviewed
May 5, 2023
eemeli
approved these changes
May 9, 2023
Comment on lines
+101
to
+102
| relative-json-pointer = origin-specification json-pointer | ||
| / origin-specification "#" |
There was a problem hiding this comment.
Suggested change
| relative-json-pointer = origin-specification json-pointer | |
| / origin-specification "#" | |
| relative-json-pointer = origin-specification ( "#" / json-pointer ) |
It might be better to not duplicate the origin-specification as it's not necessary; this equivalent formulation lets the syntax stay LL1-parseable.
There was a problem hiding this comment.
I can't seem to push to this branch. I'll create a secondary PR for this.
3 tasks
Relequestual
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1361
Adds an optional index manipulation to the syntax.It looks like this was already in the text, but the ABNF was just missing it. This PR adds the missing syntax into the ABNF.