Plain name IRI fragments can use unicode #1359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
reviewed
Dec 12, 2022
|
@handrews Like this: NCName = NCNameStartChar *NCNameChar
NCNameStartChar = "_" / ALPHA
/ %xC0-D6 / %xD8-F6 / %xF8-2FF
/ %x370-37D / %x37F-1FFF
/ %x200C-200D / %x2070-218F
/ %x2C00-2FEF / %x3001-D7FF
/ %xF900-FDCF / %xFDF0-FFFD
/ %x10000-EFFFF
NCNameChar = NCNameStartChar / "-" / "." / DIGIT
/ %xB7 / %x0300-036F / %x203F-2040However if we're not going to use ABNF for making a normative requirement, then maybe it'd be better to just give the regular expression. Or both. |
jdesrosiers
approved these changes
Mar 29, 2023
|
Replaced by ☝️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1314 as discussed in yesterday's community call. This just brings plain name fragment support into parity with the rest of our IRI support, and continues to rely on XML's NCName rule for the syntax. NCName always supported unicode, we just excluded all of it except for the US-ASCII characters.
I think I converted the W3C's grammar notation into ABNF properly, but if anyone is comfortable with ABNF (@awwright ?) a check would be appreciated. The W3C's grammar involves NCName, NCNameChar, and NCStartNameChar, which are just Name, NameChar, and StartNameChar minus the
:character. I simplified the ABNF since we did not need the:variation at all.