Remove remaining media-type param references #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Relequestual
approved these changes
Feb 10, 2022
|
Wondering if this should actually target draft-next. Thoughts? |
|
@Relequestual No, this is for the patch release. The media type parameter was removed for 2020-12, but the removal was incomplete. This just removes the piece that was missed. In it's current state, we declare the media type parameter, but the section of the spec that describes how to use it is gone. We can bring it back in some form in draft-next, but for the patch we need to fix the inconsistency. |
|
OK. Please add to changelog and merge. |
|
It's already in the change log from when it was originally removed.
https://json-schema.org/draft/2020-12/json-schema-core.html#rfc.appendix.G |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "schema" media type parameter got removed for the 2020-12 release, but some of it was missed. This removes the remaining bits.
Reference: #832