Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

add syntax highlighting for json examples #52

Merged
merged 2 commits into from
Jan 19, 2017

Conversation

mathroc
Copy link
Contributor

@mathroc mathroc commented Nov 22, 2016

Syntax highlighting is done with prism.js. there's different theme but I stayed with the default one. let me know if you like another one more ;)

I didn't add syntax highlighting in the spec documents. do you think I should ?

closes #49

@Relequestual
Copy link
Member

Thanks for the PR. I do actually need to work out how to run the site localy!
Hum. I THINK that the spec documents are built from the specification XML, although I'm not 100% sure. @awwright ?

@mathroc
Copy link
Contributor Author

mathroc commented Nov 24, 2016

@Relequestual this time I used jekyll with docker, if you already have docker installed, it really easy : https://github.com/jekyll/docker/wiki/Usage:-Running

@Relequestual
Copy link
Member

Thanks @mathroc - I don't have it installed, but there's another issue which explains how to use jekyll from commandline... think it's one of these tabs....

@agebhar1
Copy link
Contributor

agebhar1 commented Jan 7, 2017

@Relequestual if you need some help on this let me know

@Relequestual
Copy link
Member

Thanks @agebhar1, realistically I can't spend the required time this month to look at this =/

@Relequestual
Copy link
Member

@mathroc Could you set up a preview by allowing github pages on your forked version of the project? @agebhar1 did this at #69 (comment) and it made confirming a lot easier. I still haven't had time to chekcout your PR and look.

@mathroc
Copy link
Contributor Author

mathroc commented Jan 19, 2017

thx @Relequestual , I had no idea I could do that, here it is : https://mathroc.github.io/json-schema-org.github.io/

Personal preference, and also the theme is designed for max readability.
@Relequestual
Copy link
Member

Relequestual commented Jan 19, 2017

Neither did I!

Don't mind me changes theme OK THEN.

@Relequestual Relequestual merged commit ec14c2e into json-schema-org:master Jan 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax highlighting
3 participants