This repository was archived by the owner on Nov 2, 2023. It is now read-only.
Warn people about AJV's noncompliant strict mode. #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for condescending-hopper-c3ed30 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jdesrosiers
approved these changes
Aug 22, 2022
gregsdennis
approved these changes
Aug 22, 2022
handrews
force-pushed
the
ajv-strict-mode
branch
from
edf66ac to
0d8017b
Compare
|
I force-pushed so the build would work, and added a link to AJV's strict mode documentation. I don't think this really needs re-review, but I'll leave it up for a while anyway to give more time for any concerns. See also #390 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep getting confused people wondering why normal things won't work with AJV. We should at least make a note that there's something they need to do with this particular implementation. Of course this won't help people arriving at AJV other ways, but at least we could point to something.