Initialize draft6 tests from draft4. #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not currently adding tests for draft5, see issue json-schema-org#136 for discussion.
|
LGTM |
|
@Julian thanks, I don't have merge access on this repo so you'll either need to merge it or change my access, either works for me. |
|
Fixed, enjoy!
…On Jan 5, 2017 18:26, "Henry Andrews" ***@***.***> wrote:
@Julian <https://github.com/Julian> thanks, I don't have merge access on
this repo so you'll either need to merge it or change my access, either
works for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#150 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUIXtC-iNCIhB8vLMzoD1CQkI3DjCKNks5rPXwlgaJpZM4LcPXE>
.
|
|
But who tests the tests ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not currently adding tests for draft5, see issue #136 for discussion.
These are unmodified files which will be updated for draft 6 in subsequent commits.