Skip to content

Suggestion "String of 1 is not a number" test #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Relequestual opened this issue Jan 7, 2016 · 2 comments
Closed

Suggestion "String of 1 is not a number" test #110

Relequestual opened this issue Jan 7, 2016 · 2 comments

Comments

@Relequestual
Copy link
Member

A new perl module JSON::Schema::AsType has recently been released.
It uses this test suite! (Horray!)
I wonder if we should also include a test to check that a string of "1" is not a number?
Currently the code treats "1" as a number, and I figure this is not strictly correct.

@Julian
Copy link
Member

Julian commented Jan 7, 2016

Sounds great :), care for a PR?
On Jan 7, 2016 10:29, "Ben Hutton" [email protected] wrote:

A new perl module JSON::Schema::AsType has recently been released.
It uses this test suite! (Horray!)
I wonder if we should also include a test to check that a string of "1" is
not a number?
Currently the code treats "1" as a number, and I figure this is not
strictly correct.


Reply to this email directly or view it on GitHub
#110.

@Relequestual
Copy link
Member Author

Incoming by myself or a colleague shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants