Skip to content

Adds support for ETag header in GET and HEAD requests #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2021
Merged

Conversation

bart-degreed
Copy link
Contributor

See documentation updates for details.

Closes #933.

@bart-degreed bart-degreed requested a review from maurei May 14, 2021 18:54
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #998 (b0ed62c) into master (d033166) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
+ Coverage   91.26%   91.32%   +0.06%     
==========================================
  Files         281      282       +1     
  Lines        7429     7484      +55     
==========================================
+ Hits         6780     6835      +55     
  Misses        649      649              
Impacted Files Coverage Δ
...JsonApiDotNetCore/Controllers/JsonApiController.cs 80.00% <ø> (ø)
...NetCore/Configuration/JsonApiApplicationBuilder.cs 100.00% <100.00%> (ø)
.../JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs 100.00% <100.00%> (ø)
...c/JsonApiDotNetCore/Serialization/ETagGenerator.cs 100.00% <100.00%> (ø)
...c/JsonApiDotNetCore/Serialization/JsonApiWriter.cs 98.43% <100.00%> (+1.00%) ⬆️
...e/Configuration/ResourceDescriptorAssemblyCache.cs 100.00% <0.00%> (ø)
...DotNetCore/Configuration/ServiceDiscoveryFacade.cs 97.29% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d033166...b0ed62c. Read the comment docs.

@bart-degreed bart-degreed merged commit 7008d2e into master May 17, 2021
@bart-degreed bart-degreed deleted the e-tags branch May 17, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Caching: Add ETag support to save bandwidth
2 participants