Skip to content

Adds option to emit jsonapi version in response documents #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2021

Conversation

bart-degreed
Copy link
Contributor

Fixes #980.

@bart-degreed bart-degreed requested a review from maurei May 7, 2021 14:35
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #992 (9e74991) into master (d033166) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
+ Coverage   91.26%   91.28%   +0.02%     
==========================================
  Files         281      282       +1     
  Lines        7429     7448      +19     
==========================================
+ Hits         6780     6799      +19     
  Misses        649      649              
Impacted Files Coverage Δ
...JsonApiDotNetCore/Configuration/IJsonApiOptions.cs 100.00% <ø> (ø)
.../JsonApiDotNetCore/Configuration/JsonApiOptions.cs 100.00% <100.00%> (ø)
...erialization/AtomicOperationsResponseSerializer.cs 98.03% <100.00%> (+0.42%) ⬆️
.../Serialization/Objects/AtomicOperationsDocument.cs 100.00% <100.00%> (ø)
...sonApiDotNetCore/Serialization/Objects/Document.cs 100.00% <100.00%> (ø)
...iDotNetCore/Serialization/Objects/JsonApiObject.cs 100.00% <100.00%> (ø)
...nApiDotNetCore/Serialization/ResponseSerializer.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d033166...9e74991. Read the comment docs.

@bart-degreed bart-degreed merged commit e34709d into master May 18, 2021
@bart-degreed bart-degreed deleted the jsonapi-version branch May 18, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Set json-api version in responses
2 participants