Skip to content

fixed ToArray issue on dynamic object #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

manuelTscholl
Copy link

If the basetype of an relationship is ISet or ICollection a HahSet will be used.
HahSet has no implementation for ToArray it's just an extension method on Enumerable, so let's use this.

@bart-degreed
Copy link
Contributor

Just out of curiosity, as a JADNC maintainer I'm wondering about the following.

@manuelTscholl @farturi @woofi7 are you all working together on the same API project or are you unrelated individual developers that just happen to run into the same hooks problem?

@farturi
Copy link

farturi commented Feb 5, 2021

Just out of curiosity, as a JADNC maintainer I'm wondering about the following.

@manuelTscholl @farturi @woofi7 are you all working together on the same API project or are you unrelated individual developers that just happen to run into the same hooks problem?

Personally I don't know others developers

@manuelTscholl
Copy link
Author

Just out of curiosity, as a JADNC maintainer I'm wondering about the following.

@manuelTscholl @farturi @woofi7 are you all working together on the same API project or are you unrelated individual developers that just happen to run into the same hooks problem?

Looks like 3 independent developers run into the same problem.

@maurei
Copy link
Member

maurei commented Feb 5, 2021

Thanks for putting in the effort of opening up this PR! There already is a PR open for this at #938.

@woofi7
Copy link

woofi7 commented Feb 5, 2021

Just out of curiosity, as a JADNC maintainer I'm wondering about the following.

@manuelTscholl @farturi @woofi7 are you all working together on the same API project or are you unrelated individual developers that just happen to run into the same hooks problem?

I'm on my personnal project, I was upgrading tp .Net 5.0!

@maurei
Copy link
Member

maurei commented Feb 9, 2021

Closing this as it is fixed in #938

@maurei maurei closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants