Fixed: hide duplicate stacktrace for ModelState errors #905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the recent change to make
InvalidModelStateException
derive fromJsonApiException
, long (unhelpful) stack traces are returned when multiple ModelState violations occur.This is because Ben.Demystifier changes the stack trace of exceptions in-place, making it longer each time the same exception is rendered.
Adding stack traces from
ExceptionHandler
is unneeded in this case, becauseInvalidModelStateException
itself already adds any stack traces returned from ModelState validation.To illustrate, the response body for 4 violations from before this PR looked like: