Fixed: write content type on invalid Accept headers #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x to render the response as json.
|
/cc @wunki |
|
could we accept extensions to this accept header? so something like
application/vnd.api+json;domain-command=DoSomethingDomainey
Currently this doesn't work
…____________________
*Wayne Douglas*
Co-founder & Architect
*highstreet.ly <https://highstreet.ly/>*
Mobile: 07508 215459
------------------------------------
____________________
On Tue, 8 Dec 2020 at 14:07, Bart Koelman ***@***.***> wrote:
Fixed: write content type on invalid Accept headers, to enable FireFox to
render the response as json.
Before/after:
[image: image]
<https://user-images.githubusercontent.com/54280078/101493851-e10b6580-3966-11eb-91eb-fa9d7057650c.png>
------------------------------
You can view, comment on, or merge this pull request online at:
#903
Commit Summary
- Fixed: write content type on invalid Accept headers, to enable
FireFox to render the response as json.
File Changes
- *M* src/JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs
<https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/903/files#diff-26bebf1c603ab4f74aa51545c270addfae768185e914d388776d1235377fce90>
(1)
Patch Links:
- https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/903.patch
- https://github.com/json-api-dotnet/JsonApiDotNetCore/pull/903.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#903>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLPDF7OPCYME77YWAHDR3STYXIPANCNFSM4USANNBA>
.
|
maurei
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: write content type on invalid Accept headers, to enable FireFox to render the response as json.
Before/after:
