Skip to content

Feat/allow non dasherized routes #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2017
Merged

Feat/allow non dasherized routes #88

merged 4 commits into from
Apr 9, 2017

Conversation

jaredcnance
Copy link
Contributor

@jaredcnance jaredcnance commented Apr 7, 2017 •
edited
Loading

Closes #86

  • Still needs tests

Limitations:

  • Limits the use of the dasherized route convention to JsonApiControllers
  • All JsonApiController routes will be dasherized (to enable the opposite would require some extra work and breaking changes)

@jaredcnance jaredcnance requested a review from JanMattner April 8, 2017 12:45
@JanMattner
Copy link
Contributor

The changes look fine, but at least one test with a custom non-dasherized controller should be added.

@JanMattner
Copy link
Contributor

Great! I think that is sufficient for a first extensibility for custom controllers.

@jaredcnance jaredcnance merged commit c4b3361 into develop Apr 9, 2017
@jaredcnance jaredcnance deleted the feat/allow-non-dasherized-routes branch April 9, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanMattner JanMattner Awaiting requested review from JanMattner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredcnance @JanMattner