Skip to content

Included Data Should Only Contain Unique Entries #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2017
Merged

Included Data Should Only Contain Unique Entries #80

merged 2 commits into from
Mar 30, 2017

Conversation

jaredcnance
Copy link
Contributor

Closes #78
@jfhs - can you take a look at the tests here and verify that this addresses the issue you described?

@jaredcnance
test(acceptance): reproduce issue #78
47a73ac
@jaredcnance
fix(document-builder): unique inclusion of entity
0ab51ef 
ensures that an entity will only be added to the included references once
@jaredcnance jaredcnance requested a review from jfhs March 30, 2017 02:27
jfhs
jfhs reviewed Mar 30, 2017
View reviewed changes
Copy link
Contributor

@jfhs jfhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jaredcnance jaredcnance merged commit 3ca6593 into develop Mar 30, 2017
@jaredcnance jaredcnance deleted the fix/#78 branch March 30, 2017 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfhs jfhs jfhs left review comments

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredcnance @jfhs