fix(RelationshipAttribute): correct Equals and ToString #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredcnance
reviewed
Mar 23, 2017
jaredcnance
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IJsonApiContext.RelationshipsToUpdateis defined asDictionary<RelationshipAttribute, object>, howeverRelationshipAttribute.Equalsseems to compare only class name, and so, having several relationships of same type caused only first one to be saved with last one's id (which may work with autoincrement ids by chance, but immediately failed with Guids).This PR adds correct Equals which checks name and type of relationship. Also adds
ToStringfor easier debugging (I thought it is used for defaultEqualsimplementation).I didn't want to create a full acceptance test for this case, just made unit tests.