Skip to content

Feat/serializer context decoupling #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Feat/serializer context decoupling #506

wants to merge 3 commits into from

Conversation

wisepotato
Copy link
Contributor

Not yet done

but:

  • fixes an issue where the incorrect service implementation is mapped to an unrelated interface
  • Starts work on decoupling the service/repository layer
  • splits jsonapicontext in multiple classes

BUG FIX

  • reproduce issue in tests
  • fix issue
  • bump package version

FEATURE

  • write tests that address the requirements outlined in the issue
  • fulfill the feature requirements
  • bump package version

@wisepotato wisepotato added this to the v4.0 milestone May 17, 2019
@wisepotato wisepotato self-assigned this May 17, 2019
@wisepotato wisepotato added breaking-change refactor testability Increase the focus on decoupling processes/services to create a better testable environment labels May 17, 2019
@wisepotato wisepotato closed this May 23, 2019
@maurei maurei mentioned this pull request Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wisepotato wisepotato

Labels
breaking-change refactor testability Increase the focus on decoupling processes/services to create a better testable environment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wisepotato