v2.3.4 Introduce ResourceDefinition #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(DocumentBuilder): allow for output attribute filtering
feat(csproj): add SourceLink
fix(AttrAttribute): unexpected scenarios cause breaking change
specify symbols server for develop
jaredcnance
commented
Jul 5, 2018
| // There are some scenarios, especially ones where users are using a different | ||
| // data model than view model, where they may use a repository implmentation | ||
| // that does not match the deserialized type. For now, we will continue to support | ||
| // this use case. |
There was a problem hiding this comment.
Original release notes...saving for later. See the comment ☝️ for why this was not included.
We are now caching
PropertyInfowhen we build theContextGraphso that we can reduce the amount of reflection performed per-request. Previously when setting attribute values during serialization, we would look up properties by name on the incoming type. This allowed sharing repository implementations for multiple types that may have common attribute names. However, this is incorrect behavior and it has been indirectly corrected through this performance improvement.
jaredcnance
added a commit
that referenced
this pull request
Aug 12, 2018
v2.3.4 Introduce ResourceDefinition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #297
Closes #321