Add SerializerSettings to JsonApiOptions #187
Conversation
| } | ||
| } | ||
| } | ||
| public class JsonApiOptions |
There was a problem hiding this comment.
Please fix formatting here. There is no need to change the size of the whitespace, nor introduce line spaces between properties. It also makes diffs more difficult and creates noise when looking at file line history.
There was a problem hiding this comment.
I really thought I had my settings on spaces, but perhaps that is because I am used to using an editorconfig file... The extra lines where added by the CodeMaid plugin I use a lot, but I will disable that.
There was a problem hiding this comment.
That's fair. TBH I thought we had an .editorconfig :oops: thanks for mentioning it and I'll get that added.
|
|
||
| internal IContextGraphBuilder ContextGraphBuilder { get; } = new ContextGraphBuilder(); | ||
|
|
||
| public JsonSerializerSettings SerializerSettings { get; } = new JsonSerializerSettings() |
There was a problem hiding this comment.
👍
nit: let's move this to the line directly beneath the JsonContractResolver since they are related. Also, I agree that we should mark the JsonContractResolver as Obsolete
|
|
||
| return entity; | ||
| } | ||
| public class JsonApiDeSerializer : IJsonApiDeSerializer |
There was a problem hiding this comment.
Please fix whitespace formatting. I won't try to review this diff until it is absolutely clear what has been changed.
|
I made the changes, you want met to squash the commits together before it will be merged? |
|
LGTM, Thanks! I'll get a release out today or tomorrow. |
Closes #185
FEATURE
Open question: Should
JsonContractResolverproperty be madeObsoletein favor of the newSerializerSettingsproperty?