Skip to content

Refactor internal-only JSON:API extensions support #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Feb 23, 2025

Refactors non-public methods for JSON:API extension support, for consumption by OpenAPI. Pass the containing ResourceType for attributes/relationships validation.

QUALITY CHECKLIST

@bkoelman bkoelman force-pushed the refactor-extensions branch from 3e682be to 4d7fb2c Compare February 23, 2025 13:57
@bkoelman bkoelman changed the title Refactor internal-only JSON:API extensions support, add tests Refactor internal-only JSON:API extensions support Feb 23, 2025
@bkoelman bkoelman force-pushed the refactor-extensions branch from 4d7fb2c to c777ba1 Compare February 23, 2025 14:04
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (169ffee) to head (c777ba1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1687   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files         354      354           
  Lines       11536    11537    +1     
  Branches     1900     1901    +1     
=======================================
+ Hits        10462    10463    +1     
  Misses        702      702           
  Partials      372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review February 23, 2025 14:21
@bkoelman bkoelman merged commit 5902707 into master Feb 23, 2025
16 checks passed
@bkoelman bkoelman deleted the refactor-extensions branch February 23, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant