Note single project req. in common pitfalls #1676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkoelman
reviewed
Feb 13, 2025
Comment on lines
+146
to
+149
|
|
||
| #### Source generation features doesn't work on code in separated projects | ||
|
|
||
| See https://github.com/json-api-dotnet/JsonApiDotNetCore/issues/1511. |
There was a problem hiding this comment.
Thanks for the suggestion. This is already documented at https://www.jsonapi.net/usage/extensibility/controllers.html#auto-generated-controllers, which we should link to. Please move this topic after "Do not use [ApiController] on JSON:API controllers".
Suggested header name:
Don't use auto-generated controllers with shared models
Suggested text:
When model classes are defined in a separate project, the controllers are generated in that project as well, which is probably not what you want. For details, see [here](~/usage/extensibility/controllers.html#auto-generated-controllers).
|
The master branch now contains a fix for the broken build, please merge or rebase this PR on top of that. |
|
Superseded by #1679. |
|
Thanks @bkoelman 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be worth mentioning that source code generation doesn't work if the code is split out into separate project, as noted in #1511.