Merge master into openapi #1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Method | Mean | Error | StdDev | Ratio | Allocated | Alloc Ratio |
|------------------------ |---------:|---------:|---------:|------:|----------:|------------:|
| ActivatorCreateInstance | 84.13 ms | 4.029 ms | 1.046 ms | 1.00 | 69 B | 1.00 |
| LookupCached | 67.93 ms | 0.345 ms | 0.053 ms | 0.81 | 7 B | 0.10 |
```c#
using System.Collections.Concurrent;
using BenchmarkDotNet.Attributes;
namespace Benchmarks;
// ReSharper disable once ClassCanBeSealed.Global
[MarkdownExporter]
[SimpleJob(1, 5, 5)]
[MemoryDiagnoser]
public class DefaultValueBenchmarks
{
private const int IterationCount = 10_000_000;
private static readonly ConcurrentDictionary<Type, object?> Cache = new()
{
[typeof(int?)] = null,
[typeof(Guid?)] = null
};
[Benchmark(Baseline = true)]
public void ActivatorCreateInstance()
{
for (int index = 0; index < IterationCount; index++)
{
_ = Activator.CreateInstance(typeof(int?));
_ = Activator.CreateInstance(typeof(Guid?));
}
}
[Benchmark]
public void LookupCached()
{
for (int index = 0; index < IterationCount; index++)
{
_ = Cache.TryGetValue(typeof(int?), out _);
_ = Cache.TryGetValue(typeof(Guid?), out _);
}
}
}
```
Fixed: Produce error on invalid ID in request body
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## openapi #1594 +/- ##
===========================================
+ Coverage 91.39% 91.42% +0.03%
===========================================
Files 412 412
Lines 13438 13442 +4
Branches 2100 2102 +2
===========================================
+ Hits 12281 12290 +9
+ Misses 751 747 -4
+ Partials 406 405 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the master branch into openapi, which fixes the handling of empty IDs.