Skip to content

Merge master into openapi #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 25, 2024
Merged

Merge master into openapi #1570

merged 15 commits into from
Jun 25, 2024

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Jun 25, 2024

Merges the master branch into openapi, which adds operation filters.

QUALITY CHECKLIST

dependabot bot and others added 15 commits May 29, 2024 05:07
Filter operations based on GenerateControllerEndpoints usage
…ion-status-code

Return Forbidden when operation is inaccessible, to match resource endpoint status code
Remove installing PowerShell in cibuild, this is no longer needed
…sult

Fixed: return empty object instead of data:null in operation results
@bkoelman bkoelman changed the base branch from master to openapi June 25, 2024 03:56
@bkoelman bkoelman force-pushed the merge-master-into-openapi branch from 899e4a7 to 5df4928 Compare June 25, 2024 03:56
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.27%. Comparing base (18a4edf) to head (5df4928).

Files Patch % Lines
...NetCore/AtomicOperations/DefaultOperationFilter.cs 75.00% 1 Missing and 2 partials ⚠️
...ation/JsonConverters/WriteOnlyDocumentConverter.cs 72.72% 2 Missing and 1 partial ⚠️
...NetCore/AtomicOperations/IAtomicOperationFilter.cs 0.00% 2 Missing ⚠️
...ore/Controllers/BaseJsonApiOperationsController.cs 95.55% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           openapi    #1570      +/-   ##
===========================================
- Coverage    91.30%   91.27%   -0.03%     
===========================================
  Files          396      398       +2     
  Lines        12834    12905      +71     
  Branches      2028     2038      +10     
===========================================
+ Hits         11718    11779      +61     
- Misses         725      731       +6     
- Partials       391      395       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review June 25, 2024 04:15
@bkoelman bkoelman merged commit 1053099 into openapi Jun 25, 2024
18 of 28 checks passed
@bkoelman bkoelman deleted the merge-master-into-openapi branch June 25, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant