Skip to content

Remove redundant suppressions after update to CSharpGuidelinesAnalyzer v3.8.4 #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Remove redundant suppressions after update to CSharpGuidelinesAnalyzer v3.8.4 #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/JsonApiDotNetCore.SourceGenerators/ControllerSourceGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Text;

#pragma warning disable RS2008 // Enable analyzer release tracking

namespace JsonApiDotNetCore.SourceGenerators;
// To debug in Visual Studio (requires v17.2 or higher):
// - Set JsonApiDotNetCore.SourceGenerators as startup project
Expand Down
2 changes: 0 additions & 2 deletions test/JsonApiDotNetCoreTests/UnitTests/Links/LinkInclusionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,6 @@ public ResourceType GetResourceTypeForController(Type? controllerType)

private sealed class FakeLinkGenerator : LinkGenerator
{
#pragma warning disable AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
public override string GetPathByAddress<TAddress>(HttpContext httpContext, TAddress address, RouteValueDictionary values,
RouteValueDictionary? ambientValues = null, PathString? pathBase = null, FragmentString fragment = new(), LinkOptions? options = null)
{
Expand All @@ -428,6 +427,5 @@ public override string GetUriByAddress<TAddress>(TAddress address, RouteValueDic
{
throw new NotImplementedException();
}
#pragma warning restore AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
}
}