Fix code cleanup #1107
Merged
Fix code cleanup #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-degreed
force-pushed
the
fix-code-cleanup
branch
from
bcc5f9b to
037b58f
Compare
…build" This reverts commit 037b58f.
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
=======================================
Coverage 88.60% 88.60%
=======================================
Files 255 255
Lines 7160 7160
=======================================
Hits 6344 6344
Misses 816 816 Continue to review full report at Codecov.
|
maurei
approved these changes
Nov 18, 2021
bart-degreed
pushed a commit
that referenced
this pull request
Dec 3, 2021
* Disable GlobalPerProduct setting layer in cleanupcode/inspectcode * Temporary code change to verify cleanupcode still fails in cibuild * Revert "Temporary code change to verify cleanupcode still fails in cibuild" This reverts commit 037b58f. * Adapted to latest version of ReGitLint
bart-degreed
pushed a commit
that referenced
this pull request
Dec 3, 2021
* Disable GlobalPerProduct setting layer in cleanupcode/inspectcode * Temporary code change to verify cleanupcode still fails in cibuild * Revert "Temporary code change to verify cleanupcode still fails in cibuild" This reverts commit 037b58f. * Adapted to latest version of ReGitLint
bart-degreed
pushed a commit
that referenced
this pull request
Dec 3, 2021
* Disable GlobalPerProduct setting layer in cleanupcode/inspectcode * Temporary code change to verify cleanupcode still fails in cibuild * Revert "Temporary code change to verify cleanupcode still fails in cibuild" This reverts commit 037b58f. * Adapted to latest version of ReGitLint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1104.
Related to sethreno/ReGitLint#13 and sethreno/ReGitLint#14.
QUALITY CHECKLIST