Secondary paging #1100
Merged
Secondary paging #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 3, 2021 14:32
From https://jsonapi.org/format/1.1/#appendix-query-details-square-brackets: > According to the query parameter serialization rules above, a compliant implementation will percent-encode these square brackets.
…ng inverse relationship Bugfix: links.next was not set on full page at relationship endpoint
bart-degreed
force-pushed
the
secondary-paging
branch
from
cce393f to
ad5dc29
Compare
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 88.54% 88.59% +0.05%
==========================================
Files 255 255
Lines 7086 7127 +41
==========================================
+ Hits 6274 6314 +40
- Misses 812 813 +1
Continue to review full report at Codecov.
|
maurei
approved these changes
Nov 4, 2021
bart-degreed
pushed a commit
that referenced
this pull request
Dec 3, 2021
* JSON:API spec compliance: do not unescape brackets in response From https://jsonapi.org/format/1.1/#appendix-query-details-square-brackets: > According to the query parameter serialization rules above, a compliant implementation will percent-encode these square brackets. * Updated existing IResourceDefinition tests to capture all relevant callbacks * Retrieve total resource count on secondary/relationship endpoints using inverse relationship Bugfix: links.next was not set on full page at relationship endpoint * Rename flags enum to plural * Clarified documentation; fixed broken link * Check off roadmap entry
bart-degreed
pushed a commit
that referenced
this pull request
Dec 3, 2021
* JSON:API spec compliance: do not unescape brackets in response From https://jsonapi.org/format/1.1/#appendix-query-details-square-brackets: > According to the query parameter serialization rules above, a compliant implementation will percent-encode these square brackets. * Updated existing IResourceDefinition tests to capture all relevant callbacks * Retrieve total resource count on secondary/relationship endpoints using inverse relationship Bugfix: links.next was not set on full page at relationship endpoint * Rename flags enum to plural * Clarified documentation; fixed broken link * Check off roadmap entry
bart-degreed
pushed a commit
that referenced
this pull request
Dec 3, 2021
* JSON:API spec compliance: do not unescape brackets in response From https://jsonapi.org/format/1.1/#appendix-query-details-square-brackets: > According to the query parameter serialization rules above, a compliant implementation will percent-encode these square brackets. * Updated existing IResourceDefinition tests to capture all relevant callbacks * Retrieve total resource count on secondary/relationship endpoints using inverse relationship Bugfix: links.next was not set on full page at relationship endpoint * Rename flags enum to plural * Clarified documentation; fixed broken link * Check off roadmap entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
last/nextpaging links and addsmeta.totalon secondary/relationship endpoint responses whenoptions.IncludeTotalResourceCountis set totrue. Supports both one-to-many and many-to-many relationships.Fixes JSON:API spec compliance by not un-escaping square brackets in response links.
Bugfix:
links.nextwas not set on full page at relationship endpoint.Fixes #1010.
QUALITY CHECKLIST