-
-
Notifications
You must be signed in to change notification settings - Fork 158
Feature/allow leading space #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/allow leading space #1041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your input! @bart-degreed is on vacation currently, I'd like to have him have a look at it too once he returns. But for the meanwhile I've left some comments for you to look into.
test/JsonApiDotNetCoreExampleTests/UnitTests/QueryStringParameters/FilterParseTests.cs
Outdated
Show resolved
Hide resolved
test/JsonApiDotNetCoreExampleTests/UnitTests/QueryStringParameters/LegacyFilterParseTests.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 257 257
Lines 7026 7026
=======================================
Hits 6320 6320
Misses 706 706
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your contribution!
Closes #1040
QUALITY CHECKLIST