Skip to content

Feature/allow leading space #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 1, 2021

Conversation

sgryphon
Copy link
Contributor

@sgryphon sgryphon commented Aug 18, 2021

Closes #1040

QUALITY CHECKLIST

Copy link
Member

@maurei maurei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your input! @bart-degreed is on vacation currently, I'd like to have him have a look at it too once he returns. But for the meanwhile I've left some comments for you to look into.

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #1041 (205223e) into master (ea16aaf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1041   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files         257      257           
  Lines        7026     7026           
=======================================
  Hits         6320     6320           
  Misses        706      706           
Impacted Files Coverage Δ
...NetCore/Queries/Internal/Parsing/QueryTokenizer.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea16aaf...205223e. Read the comment docs.

Copy link
Contributor

@bart-degreed bart-degreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution!

@maurei maurei merged commit 16fef94 into json-api-dotnet:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Leading spaces in literals
3 participants