Skip to content

Removed Resource Hooks #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Removed Resource Hooks #1036

merged 1 commit into from
Jul 22, 2021

Conversation

bart-degreed
Copy link
Contributor

Fixes #1025.

@bart-degreed bart-degreed requested a review from maurei July 20, 2021 14:34
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #1036 (867c31c) into master (6429275) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
- Coverage   91.47%   91.06%   -0.41%     
==========================================
  Files         275      254      -21     
  Lines        7671     6896     -775     
==========================================
- Hits         7017     6280     -737     
+ Misses        654      616      -38     
Impacted Files Coverage Δ
src/JsonApiDotNetCore/CollectionConverter.cs 69.23% <ø> (ø)
...JsonApiDotNetCore/Configuration/IJsonApiOptions.cs 100.00% <ø> (ø)
...NetCore/Configuration/JsonApiApplicationBuilder.cs 100.00% <ø> (ø)
.../JsonApiDotNetCore/Configuration/JsonApiOptions.cs 100.00% <ø> (ø)
...DotNetCore/Configuration/ServiceDiscoveryFacade.cs 100.00% <ø> (+2.70%) ⬆️
...onApiDotNetCore/Services/JsonApiResourceService.cs 98.26% <100.00%> (-0.19%) ⬇️
src/JsonApiDotNetCore/TypeExtensions.cs 75.00% <0.00%> (-25.00%) ⬇️
...tCore/Configuration/ServiceCollectionExtensions.cs 84.61% <0.00%> (-15.39%) ⬇️
...c/JsonApiDotNetCore/Configuration/ResourceGraph.cs 70.96% <0.00%> (-9.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6429275...867c31c. Read the comment docs.

@maurei maurei merged commit 6b286aa into master Jul 22, 2021
@maurei maurei deleted the remove-hooks branch July 22, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove Resource Hooks
2 participants