You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rename 'entity' parameters to 'resource' in DefaultResourceService
Rename DefaultResourceRepository to EntityFrameworkCoreRepository (and update variable/parameter names likewise)
Move all types required for basic usage into JADNC's non-internal namespace. Advanced usage, like custom Service/Repository/ResourceDefinition and query filters can be in Internal namespaces. This should clarify our intent on taking breaking changes.
Make options.DefaultPageSize nullable (disallow setting to 0)
Rename T in JsonApiController<T> to TResource
Rename IQueryParameterParser to IQueryStringParser (it parses all types, not a single one)
Replace IEnumerable<> / List<> with IReadOnlyCollection<>
Review null checks
Validate input parameters on public members, validate options.
It is an implementation of a resource repository that uses ORM entities. Other implementations could be named AmazonResourceService, CachingRedisRepository etc.
Things I'd like to change:
options.DefaultPageSize
nullable (disallow setting to 0)JsonApiController<T>
to TResourceIEnumerable<>
/List<>
withIReadOnlyCollection<>
Other
The text was updated successfully, but these errors were encountered: