No DefaultPageSize leads to division by zero error #599
Labels
Comments
maurei
added a commit
that referenced
this issue
Oct 31, 2019
* feat: new startup for test * chore: rename startup class * test: reproduce #599 in test * fix: zero division error * chore: remove redundant DefaultPageSize on IPageService * chore: update .gitignore
wisepotato
pushed a commit
that referenced
this issue
Nov 11, 2019
* Fix/deviating dbset name (#603) * test: expose dbset name bug * fix: deviating dbset name * chore: add launchSettings.json to gitignore * chore: delete launchSettings.json from git * Fix/pagesize (#601) * feat: new startup for test * chore: rename startup class * test: reproduce #599 in test * fix: zero division error * chore: remove redundant DefaultPageSize on IPageService * chore: update .gitignore * fix: typo LoaDatabaseValues (#608) * fix: typo * fix: typo in fix of typo * chore: enable sql logging in JsonApiDotNetCoreExample * Acceptance tests EF inheritance (#610) * chore: create inheritance model + controller * test: create and patch acceptance test * chore: close issue * Improve usability RequestSerializer (#613) * feat: remove inability to use request serializer with unknown type at runtime * fix: typo in test setup * chore: spacing * fix: add IResourceQueryService and IResourceCmdService to DI container in application builder * chore: update comments IRequestSerializer * Move EF core related building to extension methods (#616) * feat: remove inability to use request serializer with unknown type at runtime * fix: typo in test setup * chore: spacing * fix: add IResourceQueryService and IResourceCmdService to DI container in application builder * chore: update comments IRequestSerializer * chore: moved ef core related building to extension methods * chore: spacing, rename file * refactor: remove need for internal modifier * refactor: minor refactor id type retrieval * Hooks discovery detection of implemented hooks issue (#617) * fix: discovery issue related to assemblies * fix: LoaDatabaseValue typo * fix: set EnableResourceHooks to true by default * chore: add comment in code in hooksdiscovery * fix: use IServiceProvider instead of IScopedServiceProvider * fix: discovery unit test with ServiceProvider instead of ScopedServiceProvider * refactor: TResource instead of TEntity * chore: process PR review * chore: move comment to separate line (stylecop) * feat: use camelCase as default (#618) * feat: use camelCase as default * refactor: massive replace all to replace kebab-case with camelCase default * chore: fix remaining unit tests * fix: fix remaining JsonApiDotNetCoreExampleTests * feat: introduce proper usage of WebApplicationFactory in KebabCaseFormatterTests * fix: remaining functional tests * fix: minor changes PR review * fix: camelCase revert in comments * fix: camelCase revert in comments * fix: camelCase revert in comments * fix: camelCase revert in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Using a
Startupwithout defining aIJsonApiOptions.DefaultPagesizeleads to aSystem.DivideByZeroExceptionupon a get request.The text was updated successfully, but these errors were encountered: