Skip to content

Extend sparse field selection #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wisepotato opened this issue Feb 22, 2019 · 9 comments
Closed

Extend sparse field selection #479

wisepotato opened this issue Feb 22, 2019 · 9 comments

Comments

@wisepotato
Copy link
Contributor

wisepotato commented Feb 22, 2019

From #558 :

Sparse field selection on included members in IncludedRelationshipBuilder.

Three issues:

  • Complex Attributes /nested attributes do not respond to filtering sparse fieldsets
  • Field properties (so non-properties!) do not respond to the filtering of sparse fieldsets if they are not mapped, they are included in the _dbSet filtering, which they shouldnt be, because... they're not mapped
  • (optional) adding optional fields would be great, I have some attributes that are heavy to load, and my front-end guy only wants them on certain page loads. So a sparse field that would default to not show a specific attribute would be great.
@milosloub
Copy link
Contributor

@wisepotato Do you mean this #476 (comment) ?

@wisepotato
Copy link
Contributor Author

oops! Didnt find it in search, but maybe should have looked at the recent issues.... thanks!

@milosloub
Copy link
Contributor

Yeah, the title of #476 is little bit confusing. When I was creating that issue I didn't notice, that this is common problem with sparse fields, not only repository override case

@wisepotato
Copy link
Contributor Author

the complex attributes/nested attributes do not responde to filtering sparse fieldsets still holds true i guess though.

@jaredcnance
Copy link
Contributor

  • (optional) adding optional fields would be great, I have some attributes that are heavy to load

Can this be handled by ResourceDefinition.OutputAttrs ? When you say "heavy to load", do you mean that you don't want them loaded into memory in your JADNC application, or you don't want them loaded client side?

@wisepotato
Copy link
Contributor Author

both to be honest, generation of a certain embed token takes very long, and doesnt need to be in the full list. Sure I can do this with a custom service, but I think we're here to look at integrating custom things into the core to keep th services and repositories light

@maurei
Copy link
Member

maurei commented Apr 29, 2019

@wisepotato this sounds like we can now handle this using resource hooks. Can we therefore close this issue?

@maurei maurei closed this as completed Apr 29, 2019
@wisepotato
Copy link
Contributor Author

Absolutely!

@wisepotato
Copy link
Contributor Author

Actually noy really, sparse field selection is not available in the hooks

@wisepotato wisepotato reopened this May 2, 2019
@maurei maurei closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants